Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Config in Schemas #114

Merged
merged 5 commits into from
Jul 27, 2023
Merged

Fix Config in Schemas #114

merged 5 commits into from
Jul 27, 2023

Conversation

vedem1192
Copy link
Contributor


Status

READY

Description

Fixed Config in all pydantic models inheriting from basemodel. Should be prop = value not prop: value.

Impacted Areas in Library

Schemas

Which issue(s) does this pull-request fix?

Any special notes for your reviewer?


Checklist

  • Automated tests exist
  • Updated Package Requirements (if required, and with maintainers' approval)
  • Local unit tests performed
  • Documentation exists link
  • Local pre-commit hooks performed
  • Desired commit message set as PR title and description set above
  • Link to relevant GitHub issue provided

@coveralls
Copy link

coveralls commented Jul 26, 2023

Pull Request Test Coverage Report for Build 5669652323

  • 18 of 18 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 96.219%

Totals Coverage Status
Change from base Build 5647273996: 0.004%
Covered Lines: 1883
Relevant Lines: 1957

💛 - Coveralls

@onkarbhardwaj onkarbhardwaj merged commit e05e32a into IBM:develop Jul 27, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants