Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/prompt templating #27

Merged
merged 10 commits into from
Jun 26, 2023
Merged

Feature/prompt templating #27

merged 10 commits into from
Jun 26, 2023

Conversation

vedem1192
Copy link
Contributor

@vedem1192 vedem1192 commented Jun 8, 2023 •
edited
Loading

Status

READY
*** ready but missing tests **

Description

Added support for watsonx prompt templating.

Impacted Areas in Library

PromptPattern
ServiceInterface
RequestHandler

Which issue(s) does this pull-request fix?

inner source issue number

Any special notes for your reviewer?

3 example files can be found under examples/user/prompt_templating.

Checklist

  • Automated tests exist
  • Local unit tests performed
  • Documentation exists link
  • Local pre-commit hooks performed
  • Desired commit message set as PR title and description set above

onkarbhardwaj
onkarbhardwaj reviewed Jun 9, 2023
View reviewed changes
src/genai/options.py Outdated Show resolved Hide resolved
@florenzi002 florenzi002 mentioned this pull request Jun 14, 2023
Closed
vdemers added 2 commits June 14, 2023 17:42
Async generate now works with new options object, tokenize aligned wi…
2d0c597 
…th passing options as well, fixed bug in tokenize async where we could not pass the return_token argument, made async examples
Ran pre-commit
5dd067b
@mirianfsilva mirianfsilva removed the request for review from 133martie June 15, 2023 14:52
@vedem1192 vedem1192 changed the base branch from main to develop June 15, 2023 19:07
mirianfsilva
mirianfsilva approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@mirianfsilva mirianfsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! :)

onkarbhardwaj
onkarbhardwaj reviewed Jun 20, 2023
View reviewed changes
src/genai/options.py Outdated Show resolved Hide resolved
@mirianfsilva mirianfsilva mentioned this pull request Jun 22, 2023
Closed
10 tasks
@vedem1192 @onkarbhardwaj
Update src/genai/options.py
5e65be9 
Co-authored-by: Onkar Bhardwaj <onkar.bhardwaj@gmail.com>
Signed-off-by: Veronique <veronique_1192@hotmail.com>
@coveralls
Copy link

coveralls commented Jun 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5379735072

  • 225 of 247 (91.09%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.6%) to 94.659%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/genai/options.py 9 12 75.0%
src/genai/services/prompt_template_manager.py 103 106 97.17%
src/genai/routers/prompt_template.py 36 41 87.8%
src/genai/utils/watsonx_helpers.py 1 12 8.33%
Totals Coverage Status
Change from base Build 5282489398: 2.6%
Covered Lines: 1223
Relevant Lines: 1292
💛 - Coveralls

@vedem1192 vedem1192 merged commit 5d3bfb7 into IBM:develop Jun 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onkarbhardwaj onkarbhardwaj onkarbhardwaj left review comments

@jpwsutton jpwsutton jpwsutton approved these changes

@mirianfsilva mirianfsilva mirianfsilva approved these changes

@ameza13 ameza13 Awaiting requested review from ameza13

Assignees

@vedem1192 vedem1192

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vedem1192 @coveralls @jpwsutton @onkarbhardwaj @mirianfsilva