-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retry strategy and use semaphores to prevent creating a large number of async tasks #36
Conversation
…getting created Signed-off-by: Onkar Bhardwaj <onkarbhardwaj@ibm.com>
Pull Request Test Coverage Report for Build 5417755269
💛 - Coveralls |
Signed-off-by: Onkar Bhardwaj <onkar.bhardwaj@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Signed-off-by: Onkar Bhardwaj <onkar.bhardwaj@gmail.com>
Resolved merge conflict via GUI. Hope tabs don't create an indentation issue. |
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tests are not passing after merge with develop. But the async examples works fine with +550 prompts.
Signed-off-by: Onkar Bhardwaj <onkar.bhardwaj@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and works fine with +1000 prompts.
Co-authored-by: Mírian Silva <mirianfrsilva@gmail.com> Signed-off-by: Onkar Bhardwaj <onkar.bhardwaj@gmail.com>
Status
READY
Description
generate
andtokenize
.ordered
mode ofgenerate_async
.Impacted Areas in Library
AsyncResponseGenerator
,RequestHandler
.Which issue(s) does this pull-request fix?
Closes: #15
Any special notes for your reviewer?
For testing the effect of semaphores, try sending a large number of prompts
(>200k)
with or without these changes. The exact number might differ system-to-system. For testing retry-strategy, check the dev example in this PR. This example randomly alters http return code and causes retry+backoff.Checklist