New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hotfix/async dev example #64

Merged

vedem1192 merged 1 commit into IBM:develop from mirianfsilva:hotfix/async-examples

Jun 30, 2023

Member

mirianfsilva commented Jun 29, 2023

Status

READY

Description

Update async flaky dev example, that was receiving None in all responses.

Impacted Areas in Library

dev examples

Which issue(s) does this pull-request fix?

Any special notes for your reviewer?

Checklist

Automated tests exist
Updated Package Requirements (if required, and with maintainers' approval)
Local unit tests performed
Documentation exists link
Local pre-commit hooks performed
Desired commit message set as PR title and description set above
Link to relevant GitHub issue provided


          add options - flaky async dev example

60effd7

Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>

mirianfsilva requested review from ameza13, vedem1192 and moneill0

June 29, 2023 16:05

coveralls commented Jun 29, 2023 •

edited

Loading

Pull Request Test Coverage Report for Build 5414372531

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.659%

Totals
Change from base Build 5379768299:	0.0%
Covered Lines:	1223
Relevant Lines:	1292

💛 - Coveralls

mirianfsilva requested a review from jayolee

June 30, 2023 17:03

onkarbhardwaj approved these changes

View reviewed changes

Contributor

onkarbhardwaj left a comment

Tests all right.

vedem1192 approved these changes

View reviewed changes

vedem1192 merged commit 22c2a1f into IBM:develop

4 checks passed

mirianfsilva deleted the hotfix/async-examples branch

July 7, 2023 15:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

onkarbhardwaj onkarbhardwaj approved these changes

vedem1192 vedem1192 approved these changes

ameza13 Awaiting requested review from ameza13

moneill0 Awaiting requested review from moneill0

jayolee Awaiting requested review from jayolee