Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/prompt tuning #77

Merged
merged 56 commits into from
Jul 10, 2023
Merged

Feature/prompt tuning #77

merged 56 commits into from
Jul 10, 2023

Conversation

onkarbhardwaj
Copy link
Contributor

@onkarbhardwaj onkarbhardwaj commented Jul 5, 2023 •
edited
Loading

Status

READY

Description

Interfaces for files, tunes. Model class would have a tune method.

Impacted Areas in Library

Services, Schemas, Model

Any special notes for your reviewer?

Checklist

  • Automated tests exist
  • Updated Package Requirements (if required, and with maintainers' approval)
  • Local unit tests performed
  • Documentation exists link
  • Local pre-commit hooks performed
  • Desired commit message set as PR title and description set above
  • Link to relevant GitHub issue provided

onkarbhardwaj and others added 20 commits June 22, 2023 15:18
@onkarbhardwaj
Merge pull request #1 from IBM/develop
dd8b702 
Merge upstream
@onkarbhardwaj
Merge branch 'IBM:develop' into develop
1ae83f9
@mirianfsilva @moneill0
init prompt tuning: add examples -files and tunes
b353c3e 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva @moneill0
add schemas
eade6f7 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva
init file services
cce1c01 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva @moneill0
init tune services
9d85108 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: Mairead O'Neill <moneill@ibm.com>
@moneill0
feat: tune manager
edda015 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
@moneill0
fix: fixed tunes router
7878761 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
@moneill0
fix: fix merge conflicts
e36af10 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva @moneill0
update imports from file example, update routers
e79844d 
- fix circular import from routers that use service interface (temporary
  solution)
- add routers in the service interface

Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva
add tests for files
afd0571 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva @moneill0
update tunes doc-strings
1dcec66 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva
request handler changes - add files to httpx POST methods
72eb7ce 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva
update files docstrings, improve tests
c80824f 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva
fix delete file tests
1cc0390 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva @moneill0
add tunes tests
46a46f2 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva @moneill0
tunes examples updates
ddae508 
- update the imports from tunes examples (all working)
- fix create tune call - update payload to options

Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
Co-authored-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva
add new file-tune example
9e0ddd4 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@onkarbhardwaj
add descriptions and adjust imports
860a869
@mirianfsilva
fix pre-commit
b0f4b76 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@coveralls
Copy link

coveralls commented Jul 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5512480688

  • 337 of 339 (99.41%) changed or added relevant lines in 16 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 95.606%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/genai/utils/service_utils.py 8 10 80.0%
Totals Coverage Status
Change from base Build 5510311863: 0.9%
Covered Lines: 1545
Relevant Lines: 1616
💛 - Coveralls

Onkar Bhardwaj and others added 4 commits July 6, 2023 14:23
unit tests
74fb5d7
@moneill0
test: tune manager pytests
294c1d4 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
@mirianfsilva
improve response helper for tests
26b5373 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@moneill0
fix: fixed get tunes schema check
2500b87 
Signed-off-by: Mairead O'Neill <moneill@ibm.com>
mirianfsilva and others added 22 commits July 7, 2023 17:18
@mirianfsilva
accept ServiceInterface as credentials - FileManager
f057609 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva
accept ServiceInterface as credentials - TuneManager
fdad69e 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva
Merge pull request #5 from onkarbhardwaj/init-service
5f8661e 
accept ServiceInterface as credentials - FileManager, TuneManager
@mirianfsilva
update examples
99a1e15 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
FileManager and TuneManager can take both creds and servie interface
e879b06
align examples with changed method signatures
ec7f9c6
@mirianfsilva
update schemas, docs strings, error messages
6faf133 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
Examples for classification and summarization
20701a5
@onkarbhardwaj
Revert "accept ServiceInterface as credentials - FileManager, TuneMan…
91670ae 
…ager"
@onkarbhardwaj
Merge pull request #7 from onkarbhardwaj/revert-5-init-service
0597c25 
Revert "accept ServiceInterface as credentials - FileManager, TuneManager"
@onkarbhardwaj
Merge pull request #8 from onkarbhardwaj/feature/prompt-tuning-model
fad838c 
Feature/prompt tuning model
remove examples that were superseded
a9c2bb6
@onkarbhardwaj
Merge pull request #9 from onkarbhardwaj/feature/prompt-tuning-model
4095d5c 
remove examples that were superseded
@mirianfsilva
update branch
8ad6014
@mirianfsilva
update docstrings
8444216 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva
update schema
4087147 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@mirianfsilva
Merge pull request #6 from onkarbhardwaj/review
ca84efd 
update schemas, docs strings, error messages
@mirianfsilva
update tests
8d9250f 
Signed-off-by: Mírian Silva <mirianfrsilva@ibm.com>
@onkarbhardwaj
Merge branch 'IBM:develop' into develop
d56564c
@onkarbhardwaj
Merge pull request #11 from onkarbhardwaj/develop
08678f7 
Sync upstream
Moved sanitize param to utils folder to remove circular import
435ec16
@onkarbhardwaj
Merge pull request #12 from onkarbhardwaj/feature/prompt-tuning-vdemers
f81b360 
Moved sanitize param to utils folder to remove circular import
@onkarbhardwaj onkarbhardwaj marked this pull request as ready for review July 10, 2023 20:13
@vedem1192 vedem1192 merged commit 0a3cea0 into IBM:develop Jul 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedem1192 vedem1192 vedem1192 approved these changes

@moneill0 moneill0 moneill0 approved these changes

@jpwsutton jpwsutton Awaiting requested review from jpwsutton

@ameza13 ameza13 Awaiting requested review from ameza13

@mirianfsilva mirianfsilva Awaiting requested review from mirianfsilva

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@onkarbhardwaj @coveralls @vedem1192 @mirianfsilva @moneill0