Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc/open source doc updates3 #79

Merged
merged 6 commits into from
Jul 10, 2023
Merged

Doc/open source doc updates3 #79

merged 6 commits into from
Jul 10, 2023

Conversation

ameza13
Copy link
Member

@ameza13 ameza13 commented Jul 6, 2023 •
edited
Loading

Status

READY

Description

Updating markdown files to comply with IBM's Inner Source project pattern.

Impacted Areas in Library

Markdown files only

Which issue(s) does this pull-request fix?

Closes: #78

Any special notes for your reviewer?

  • Please check that all links work in markdown files.
  • Pleas look for typos in README file as some bullets were added.
  • Links in API doc to the files that changed must be updated as some were renamed. Should we create an issue for that?

Checklist

  • Automated tests exist
  • Updated Package Requirements (if required, and with maintainers' approval)
  • Local unit tests performed
  • Documentation exists link
  • Local pre-commit hooks performed
  • Desired commit message set as PR title and description set above
  • Link to relevant GitHub issue provided

Adriana Meza Soria added 3 commits July 6, 2023 14:24
markdown files updates and content re-distribution to complay with in…
1e6a0b3 
…nersource project template

Signed-off-by: Adriana Meza Soria <Adriana.Meza.Soria@ibm.com>
starter team update
0e3ada1 
Signed-off-by: Adriana Meza Soria <Adriana.Meza.Soria@ibm.com>
README update
2394d2f 
Signed-off-by: Adriana Meza Soria <Adriana.Meza.Soria@ibm.com>
@ameza13 ameza13 force-pushed the doc/open-source-doc-updates3 branch from 6dfb9d7 to 2394d2f Compare July 6, 2023 18:24
@coveralls
Copy link

coveralls commented Jul 6, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5512575004

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 94.688%
Totals Coverage Status
Change from base Build 5425902251: -0.05%
Covered Lines: 1230
Relevant Lines: 1299
💛 - Coveralls

@ameza13 ameza13 self-assigned this Jul 6, 2023
@ameza13 ameza13 requested review from vedem1192 and jayolee July 6, 2023 18:28
innersource yaml file update
9eca6c2 
Signed-off-by: Adriana Meza Soria <Adriana.Meza.Soria@ibm.com>
@ameza13 ameza13 marked this pull request as ready for review July 7, 2023 16:06
@ameza13 ameza13 added the documentation Improvements or additions to documentation label Jul 7, 2023
@ameza13 ameza13 linked an issue Jul 7, 2023 that may be closed by this pull request
Re-organization and updates to markdown files with project info #78
Closed
vedem1192
vedem1192 reviewed Jul 10, 2023
View reviewed changes
GETTING_STARTED.md Outdated Show resolved Hide resolved
vedem1192
vedem1192 reviewed Jul 10, 2023
View reviewed changes
Copy link
Contributor

@vedem1192 vedem1192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment about model type

@vedem1192
Update GETTING_STARTED.md
06365a5 
Signed-off-by: Veronique <22043067+vedem1192@users.noreply.github.com>
moneill0
moneill0 reviewed Jul 10, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
vedem1192
vedem1192 reviewed Jul 10, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@vedem1192
Update README.md
ebc6b94 
Signed-off-by: Veronique <22043067+vedem1192@users.noreply.github.com>
@vedem1192 vedem1192 merged commit 4bd3be4 into IBM:develop Jul 10, 2023
4 checks passed
@ameza13 ameza13 deleted the doc/open-source-doc-updates3 branch July 14, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedem1192 vedem1192 vedem1192 approved these changes

@onkarbhardwaj onkarbhardwaj onkarbhardwaj approved these changes

@moneill0 moneill0 moneill0 approved these changes

@jayolee jayolee Awaiting requested review from jayolee

Assignees

@ameza13 ameza13

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-organization and updates to markdown files with project info
5 participants
@ameza13 @coveralls @onkarbhardwaj @vedem1192 @moneill0