Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More debugger functionality (deadlock detection, single-stepping, complex breakpoints conditions, etc) #340

Merged
merged 28 commits into from Aug 5, 2022

Conversation

jacobdunefsky
Copy link
Contributor

No description provided.

Jacob Dunefsky added 23 commits July 15, 2022 10:24
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
… around)

Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
…ndlerDebugger

Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
@dgrove-oss
Copy link
Member

Two high-level comments on the changes in examples:

  1. We don't check in .yalc files; probably got added by mistake? In any case, please remove.
  2. The ykt example failed in several of the test runs. I tried re-executing them, but it might be expedient to drop the changes to ykt.js from this PR and try it in a PR just by itself.

@dgrove-oss
Copy link
Member

Re-execution of the failing jobs yielded the same failures in ykt test scenarios. Definitely try removing the changes to ykt.js to rule that out as the cause.

Jacob Dunefsky added 3 commits August 4, 2022 13:57
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Jacob Dunefsky added 2 commits August 5, 2022 12:35
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
Signed-off-by: Jacob Dunefsky <jacob.dunefsky@ibm.com>
@dgrove-oss dgrove-oss merged commit 1f9e128 into IBM:main Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants