Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugins/plugin-client-common): restore history navigation behavio… #5376

Merged
merged 1 commit into from Aug 17, 2020

Conversation

starpit
Copy link
Contributor

@starpit starpit commented Aug 17, 2020

…r in minisplits

and instead use PageUp/PageDown to navigate blocks

Fixes #5375

Description of what you did:

My PR is a:

  • 💥 Breaking change
  • 🐛 Bug fix
  • 💅 Enhancement
  • 🚀 New feature

Please confirm that your PR fulfills these requirements

  • Multiple commits are squashed into one commit.
  • The commit message follows Conventional Commits, which allows us to autogenerate release notes; e.g. fix(plugins/plugin-k8s): fixed annoying bugs
  • All npm dependencies are pinned.

…r in minisplits

and instead use PageUp/PageDown to navigate blocks

Fixes kubernetes-sigs#5375
@codecov
Copy link

codecov bot commented Aug 17, 2020

Codecov Report

Merging #5376 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5376   +/-   ##
=======================================
  Coverage   59.04%   59.04%           
=======================================
  Files          78       78           
  Lines        2544     2544           
  Branches      629      629           
=======================================
  Hits         1502     1502           
  Misses        797      797           
  Partials      245      245           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b623e4e...f921300. Read the comment docs.

@starpit starpit closed this Aug 17, 2020
@starpit starpit reopened this Aug 17, 2020
@starpit starpit closed this Aug 17, 2020
@starpit starpit reopened this Aug 17, 2020
@starpit starpit merged commit 26f49e8 into kubernetes-sigs:master Aug 17, 2020
@starpit starpit deleted the fix-5375 branch August 17, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

restore history navigation in minisplits
1 participant