Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restore history navigation in minisplits #5375

Closed
starpit opened this issue Aug 17, 2020 · 0 comments · Fixed by #5376
Closed

restore history navigation in minisplits #5375

starpit opened this issue Aug 17, 2020 · 0 comments · Fixed by #5376

Comments

@starpit
Copy link
Contributor

starpit commented Aug 17, 2020 •
edited

earlier, we made the up/down arrows navigate Blocks in minisplits, rather than navigating command history for the active prompt (as is usually the case for Terminals).

we need to revert this, as it is very awkward; instead, I propose we use PageUp/PageDown for block-level navigation. since each Block in a minisplit is maximized, commandeering PageUp/PageDown should not have any unintended harm to UX.
starpit added a commit to starpit/kui that referenced this issue Aug 17, 2020
@starpit
fix(plugins/plugin-client-common): restore history navigation behavio…
f921300 
…r in minisplits

and instead use PageUp/PageDown to navigate blocks

Fixes kubernetes-sigs#5375
@starpit starpit mentioned this issue Aug 17, 2020
Merged
7 tasks
starpit added a commit that referenced this issue Aug 17, 2020
@starpit
fix(plugins/plugin-client-common): restore history navigation behavio…
26f49e8 
…r in minisplits

and instead use PageUp/PageDown to navigate blocks

Fixes #5375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(plugins/plugin-client-common): restore history navigation behavio… starpit/kui
1 participant
@starpit