Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect Lale autogen to lale.lib.sklearn where overlap #1123

Closed
hirzel opened this issue Jul 11, 2022 · 1 comment
Closed

redirect Lale autogen to lale.lib.sklearn where overlap #1123

hirzel opened this issue Jul 11, 2022 · 1 comment

Comments

@hirzel
Copy link
Member

hirzel commented Jul 11, 2022

There are 43 operators that exist in both lale.lib.autogen and lale.lib.sklearn. This overlap is problematic, because it can lead to unexpected behavior depending on the order of imports, and users might end up with a lower-quality version of an operator for which we also have a higher-quality version. We should simply remove lale.lib.autogen operators from the repository for which there is also a lale.lib.sklearn operator. To avoid breaking code that uses them, we can change the __init__.py file of lale.lib.autogen to forward to the relevant replacements.

List of duplicate operators: ada_boost_classifier, ada_boost_regressor, decision_tree_classifier, decision_tree_regressor, extra_trees_classifier, extra_trees_regressor, function_transformer, gaussian_nb, gradient_boosting_classifier, gradient_boosting_regressor, isomap, k_means, k_neighbors_classifier, k_neighbors_regressor, linear_regression, linear_svc, linear_svr, logistic_regression, min_max_scaler, missing_indicator, mlp_classifier, multinomial_nb, nmf, normalizer, nystroem, one_hot_encoder, ordinal_encoder, passive_aggressive_classifier, pca, polynomial_features, quadratic_discriminant_analysis, quantile_transformer, random_forest_classifier, random_forest_regressor, ridge, ridge_classifier, robust_scaler, sgd_classifier, sgd_regressor, simple_imputer, standard_scaler, svc, svr

hirzel added a commit to hirzel/lale that referenced this issue Feb 10, 2023
Signed-off-by: Martin Hirzel <hirzel@gmail.com>
hirzel added a commit that referenced this issue Feb 10, 2023
* Fix issue #1123.

Signed-off-by: Martin Hirzel <hirzel@gmail.com>

* Remove tests for removed operators.

Signed-off-by: Martin Hirzel <hirzel@gmail.com>

---------

Signed-off-by: Martin Hirzel <hirzel@gmail.com>
@hirzel
Copy link
Member Author

hirzel commented Feb 11, 2023

Fixed by #1299.

@hirzel hirzel closed this as completed Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant