ignore errors to communicate with live cluster if it is not an explicit requirement #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vided explicitly by user Signed-off-by: shireenf-ibm <shireenf@il.ibm.com>
adisos
reviewed
Nov 10, 2022
adisos
reviewed
Nov 10, 2022
Signed-off-by: shireenf-ibm <shireenf@il.ibm.com>
adisos
reviewed
Nov 10, 2022
| @@ -95,7 +98,7 @@ def get_k8s_resources(resource): | |||
| cmdline_list = ['kubectl', 'get', resource, '-o=json'] | |||
| if resource in ['networkPolicy', 'authorizationPolicy', 'pod', 'ingress', 'Gateway', 'VirtualService', 'sidecar']: | |||
| cmdline_list.append('--all-namespaces') | |||
| return CmdlineRunner.run_and_get_output(cmdline_list) | |||
| return CmdlineRunner.run_and_get_output(cmdline_list, check_for_silent_exec=True) | |||
There was a problem hiding this comment.
Shouldn't also be set True from get_calico_resources, not only from get_k8s_resources ?
There was a problem hiding this comment.
currently if the topology section is missing / or user runs cmdline without resources or without policies - our default is to load missing resources from k8s live cluster - so it is the only relevant case for a silent attempt
we load from calico only if the input is calico - a provided "live cluster" input does not ignore errors for any of the layers
adisos
approved these changes
Nov 10, 2022
shireenf-ibm
deleted the
issue_351_support_scheme_w_missing_global_section
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#351
any implicit attempt to load from k8s live cluster will occur silently
explicit attempts (e.g. k8s is an input resource) - runs as usual (communication errors are not ignored)
Signed-off-by: shireenf-ibm shireenf@il.ibm.com