Fixed recursive operations (and/or/sub) in hyper cube set, to not ch… #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge self during the recursive (sub)calls. Signed-off-by: Tanya <tatyana@il.ibm.com>
Signed-off-by: adisos <adisos@il.ibm.com>
Closed
adisos
approved these changes
Nov 28, 2022
adisos
reviewed
Nov 28, 2022
nca/CoreDS/CanonicalHyperCubeSet.py
Outdated
| res_layers = dict() | ||
| for self_layer in self.layers: | ||
| for other_layer in other.layers: | ||
| common_elem = self_layer & other_layer | ||
| if not common_elem: | ||
| continue | ||
| if self._is_last_dimension(): | ||
| res_layers[common_elem] = self.layers[self_layer] | ||
| res_layers[common_elem] = self.layers[self_layer].copy() |
adisos
requested changes
Nov 28, 2022
Signed-off-by: Tanya <tatyana@il.ibm.com>
adisos
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ange self during the recursive (sub)calls.
Signed-off-by: Tanya tatyana@il.ibm.com