-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to axios 1.2.1 #217
Conversation
@ricellis This PR is looking great. I merged in the new cookie support so once you have this branch updated with the new cookie code, I can cut a new (potentially final) beta to test before merging this |
BREAKING CHANGE: Minimum Node.js version is 14. Upgrade to at least Node.js 14. Signed-off-by: Rich Ellis <ricellis@users.noreply.github.com>
Signed-off-by: Rich Ellis <ricellis@users.noreply.github.com>
Signed-off-by: Rich Ellis <ricellis@users.noreply.github.com>
BREAKING CHANGE: Minimum typescript version is 4. Upgrade to typescript 4.x. Signed-off-by: Rich Ellis <ricellis@users.noreply.github.com>
Signed-off-by: Rich Ellis <ricellis@users.noreply.github.com>
build-request-file-object.test.js and get-content-type.test.js both make use of streams with non-existent paths to check errors. Possibly since upgrading jest these cause suites to fail with e.g. ``` Error: ENOENT: no such file or directory, open '/fake/path/custom-name.env' Emitted 'error' event on ReadStream instance at: at emitErrorNT (node:internal/streams/destroy:157:8) at emitErrorCloseNT (node:internal/streams/destroy:122:3) at processTicksAndRejections (node:internal/process/task_queues:83:21) { errno: -2, code: 'ENOENT', syscall: 'open', path: '/fake/path/custom-name.env' ``` Since the errors are expected for these tests add a no-op handler to handle the error events. Signed-off-by: Rich Ellis <ricellis@users.noreply.github.com>
746505f
to
e884861
Compare
Thanks @dpopp07 - I've updated this ready for another round of beta testing that definitely seems like a good plan! |
Great - the new beta has been published! Let me know how testing goes. If all is well, I'll merge tomorrow |
@dpopp07 our tests are still looking green with |
Great!
Great point. We spent some time yesterday doing additional testing with the Platform Service SDKs and everything looks green on that end too. I think we're looking good to ship |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for all of your work on this and for crafting your commit messages so well 👍
🎉 This PR is included in version 4.0.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Axios 0.x is not maintained any more and the 1.x stream contains some useful fixes (see also #209).
This PR is a cleaned up version of #213, but note that this PR requires #216 as a prerequisite
(and since that is currently unmerged this PR also currently contains the commit from that PR). If there areaxios-cookiejar-support
changes then it may be possible to drop #216 and refactor this instead.There are potentially breaking changes here because:
Commit summary:
994a25c - from refactor: cookie support via interceptors #216 PREREQ1.2.1
paramsSerializer
legacy compatibilityserialize
function with existing stringify function.withCredentials
from axios defaults.build-request-file-object.test.js
andget-content-type.test.js
both make use of streams with non-existent paths to check errors. Possibly since upgrading jest these cause suites to fail with e.g.Checklist
npm test
passes (tip:npm run lint-fix
can correct most style issues)