fix: ssh transport silent failure (#225)

IBM · Apr 17, 2020 · 6e3b8a0 · 6e3b8a0
1 parent dddbbed
commit 6e3b8a0
Showing 1 changed file with 2 additions and 9 deletions.
diff --git a/lib/transports/sshTransport.js b/lib/transports/sshTransport.js
@@ -22,7 +22,6 @@ function sshCall(config, xmlIn, done) {
     verbose = false,
   } = config;
 
-  let ERROR;
   let xmlOut = '';
   const xmlBuffer = Buffer.from(xmlIn);
 
@@ -33,8 +32,8 @@ function sshCall(config, xmlIn, done) {
     if (verbose) {
       console.log('SSH CLIENT ERROR: ', error);
     }
-    ERROR = error;
     client.end();
+    done(error, null);
   });
 
   client.on('close', () => {
@@ -47,13 +46,6 @@ function sshCall(config, xmlIn, done) {
     if (verbose) {
       console.log('SSH Client has ended');
     }
-
-    if (ERROR) {
-      done(ERROR, null);
-      return;
-    }
-
-    done(null, xmlOut);
   });
 
   client.on('ready', () => {
@@ -86,6 +78,7 @@ function sshCall(config, xmlIn, done) {
           return;
         }
         client.end();
+        done(null, xmlOut);
       });
 
       stream.stdin.on('end', () => {