Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Specify supported Node versions #264

Merged
merged 1 commit into from
Apr 22, 2020
Merged

feat: Specify supported Node versions #264

merged 1 commit into from
Apr 22, 2020

Conversation

kadler
Copy link
Member

@kadler kadler commented Apr 22, 2020

No description provided.

@kadler kadler requested a review from abmusse April 22, 2020 17:53
abmusse
abmusse approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@abmusse abmusse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I viewed the file and currently it shows up as

image

I'm thinking its currently unspecified because the badge retrieves engines.node from package.json from master which does not exist yet.

@kadler
Copy link
Member Author

kadler commented Apr 22, 2020

It retrieves it from the npm package itself IIRC, so we'll have to publish new versions before it actually works.

@kadler kadler merged commit 63ec53c into master Apr 22, 2020
@kadler kadler deleted the node-engines branch April 22, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abmusse abmusse abmusse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kadler @abmusse