Skip to content

Conversation

@kadler
Copy link
Member

@kadler kadler commented Apr 22, 2020

No description provided.

@kadler kadler requested a review from abmusse April 22, 2020 17:53
Copy link
Member

@abmusse abmusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I viewed the file and currently it shows up as

image

I'm thinking its currently unspecified because the badge retrieves engines.node from package.json from master which does not exist yet.

@kadler
Copy link
Member Author

kadler commented Apr 22, 2020

It retrieves it from the npm package itself IIRC, so we'll have to publish new versions before it actually works.

@kadler kadler merged commit 63ec53c into master Apr 22, 2020
@kadler kadler deleted the node-engines branch April 22, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants