Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fix mocha/no-identical-title eslint issue #296

Merged
merged 1 commit into from
Dec 8, 2020
Merged

test: Fix mocha/no-identical-title eslint issue #296

merged 1 commit into from
Dec 8, 2020

Conversation

abmusse
Copy link
Member

@abmusse abmusse commented Jul 13, 2020

Part of #289

@abmusse abmusse requested a review from kadler July 13, 2020 16:51
@github-actions
Copy link

👋 Hi! This pull request has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Aug 13, 2020
@abmusse abmusse added the keep-open Exempts stale action from auto closing the issue/pr. label Aug 13, 2020
@github-actions github-actions bot closed this Oct 6, 2020
@kadler kadler removed the stale label Oct 6, 2020
@kadler kadler reopened this Oct 6, 2020
kadler
kadler approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@kadler kadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no more identical titles, but the descriptions seem a bit terse. Is that the normal practice for Mocha?

@abmusse
Copy link
Member Author

abmusse commented Dec 8, 2020

So the describe blocks are in a sense the test suite and each individual it block is the actually test case in the suite. For our tests I made describe blocks for each method of the Class to test it. In the case of ProgramCall we have the addParam and addReturn describe blocks which are pretty terse but the individual it blocks would have a the description of the actually test case. We could definetly add more detail to the describe block if we want to. From the mochajs examples I've seen this is usually the case for instance the Express test cases. Here is a list of some other examples.

@kadler
Copy link
Member

kadler commented Dec 8, 2020

Ok, sounds good to me.

@kadler kadler merged commit 8bb5860 into master Dec 8, 2020
@kadler kadler deleted the fix-no-identical-title branch December 8, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadler kadler kadler approved these changes

Assignees
No one assigned
Labels
keep-open Exempts stale action from auto closing the issue/pr.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abmusse @kadler