Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix mocha/no-hooks-for-single-case eslint issue #297

Merged
merged 1 commit into from
Dec 8, 2020

Conversation

abmusse
Copy link
Member

@abmusse abmusse commented Jul 13, 2020

Part of #289

Removed the before hook and moved the hooks' operations in the test directly.

See https://github.com/lo1tuma/eslint-plugin-mocha/blob/master/docs/rules/no-hooks-for-single-case.md

@abmusse abmusse marked this pull request as ready for review July 13, 2020 22:05
@github-actions
Copy link

👋 Hi! This pull request has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Aug 13, 2020
@abmusse abmusse added the keep-open Exempts stale action from auto closing the issue/pr. label Aug 13, 2020
@github-actions github-actions bot closed this Oct 6, 2020
@kadler kadler removed the stale label Oct 6, 2020
@kadler kadler reopened this Oct 6, 2020
@abmusse abmusse force-pushed the fix-no-hooks-for-single-case branch from 9053c97 to f937693 Compare December 8, 2020 19:23
@kadler kadler merged commit cb5d077 into master Dec 8, 2020
@kadler kadler deleted the fix-no-hooks-for-single-case branch December 8, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep-open Exempts stale action from auto closing the issue/pr.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants