Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Handle optional dependencies better #306

Merged
merged 2 commits into from
Dec 8, 2020
Merged

refactor: Handle optional dependencies better #306

merged 2 commits into from
Dec 8, 2020

Conversation

abmusse
Copy link
Member

@abmusse abmusse commented Jul 23, 2020

Resolves #290

@abmusse abmusse requested a review from kadler July 23, 2020 23:17
@github-actions
Copy link

👋 Hi! This pull request has been marked stale due to inactivity. If no further activity occurs, it will automatically be closed.

@github-actions github-actions bot added the stale label Aug 24, 2020
@abmusse abmusse added the keep-open Exempts stale action from auto closing the issue/pr. label Aug 24, 2020
@github-actions github-actions bot closed this Oct 6, 2020
@kadler kadler removed the stale label Oct 6, 2020
@kadler kadler reopened this Oct 6, 2020
kadler
kadler approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@kadler kadler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small comment

lib/transports/idbTransport.js Outdated Show resolved Hide resolved
@kadler kadler merged commit c02b799 into master Dec 8, 2020
@kadler kadler deleted the handle-optional-deps branch December 8, 2020 16:54
@abmusse abmusse mentioned this pull request Jan 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadler kadler kadler approved these changes

Assignees
No one assigned
Labels
keep-open Exempts stale action from auto closing the issue/pr.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle optional dependencies better
2 participants
@abmusse @kadler