Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add omit as valid value for io #346

Merged
merged 1 commit into from
Oct 25, 2022
Merged

docs: Add omit as valid value for io #346

merged 1 commit into from
Oct 25, 2022

Conversation

alanseiden
Copy link
Contributor

@alanseiden alanseiden commented Oct 14, 2022 •
edited by abmusse

Resolves #343

@alanseiden alanseiden mentioned this pull request Oct 14, 2022
Closed
@alanseiden
Copy link
Contributor Author

@abmusse What do you think? This PR would resolve #343

@abmusse abmusse self-requested a review October 20, 2022 15:21
abmusse
abmusse reviewed Oct 20, 2022
View reviewed changes
Copy link
Member

@abmusse abmusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM.

Before merging can you please sign off the commit for DCO to pass.

Also can you fixup the commit message with the docs: prefix?

docs: Add omit as valid value for io

We use conventional commits for our commits.

@alanseiden alanseiden changed the title Add omit as valid value for io Add omit as valid value for io Signed-off-by: Author Name <authoremail@example.com> Oct 20, 2022
@alanseiden alanseiden changed the title Add omit as valid value for io Signed-off-by: Author Name <authoremail@example.com> Add omit as valid value for io Oct 20, 2022
@alanseiden alanseiden changed the title Add omit as valid value for io docs: Add omit as valid value for io Oct 20, 2022
@alanseiden
docs: Add omit as valid value for io
b9dd015 
Signed-off-by: Alan Seiden <alan@alanseiden.com>
abmusse
abmusse approved these changes Oct 25, 2022
View reviewed changes
Copy link
Member

@abmusse abmusse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abmusse abmusse merged commit 6567f2e into IBM:master Oct 25, 2022
This was referenced Oct 25, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abmusse abmusse abmusse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

*OMIT not supported
2 participants
@alanseiden @abmusse