fix: Better optional deps handling #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The odbc and idb are optional deps that might not be installed. When either is not available, return an error back to user instead of failing.
abmusse
force-pushed
the
better-optional-deps-error-messages
branch
from
2b3b4a0
to
53f9bf1
Compare
markdirish
requested changes
Oct 27, 2022
lib/transports/idbTransport.js
Outdated
| @@ -28,6 +28,11 @@ try { | |||
| } | |||
|
|
|||
| function idbCall(config, xmlInput, cb) { | |||
| // idb transport is not available bail out | |||
| if (idb === null) { | |||
| cb(new Error('idb-connector module was not found, the idb transport is only usable on IBM i.'), null); | |||
There was a problem hiding this comment.
Maybe something like
"idb-connector was not found, ensure idb-connector is installed properly (idb-connector is only available on IBM i)"
I get nervous about the term "module", since idb-connector doesn't have type: module in its package.json, which affects all sorts of things (CJS vs. ESM modules)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
odbc and idb-connector are optional deps and might not be installed.
When either is not available, return an error back to user instead of failing.
Fixes #317