Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reading time format #72

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

janikn67
Copy link
Member

Current nzpy implementation is not adjusted to include microseconds while reading time type and Netezza supports time type with microseconds resolution from 00:00:00.000000 to 23:59:59.999999. When microseconds are equal to 0, they are not displayed:

SYSTEM.ADMIN(ADMIN)=> select * from test_time;
      TIME       
-----------------
 01:00:01
 01:02:03.004005
 00:00:00
 23:59:59.999999
(4 rows)

SYSTEM.ADMIN(ADMIN)=> insert into test_time values ('12:30:30.000000');
INSERT 0 1
SYSTEM.ADMIN(ADMIN)=> select * from test_time;
      TIME       
-----------------
 01:00:01
 01:02:03.004005
 00:00:00
 23:59:59.999999
 12:30:30
(5 rows)

Provided fix adds microseconds to the time and adjusts the display depending on their value.

Testing:

  • most of the tests passed - observed ERROR: Function 'XMLPARSE(UNKNOWN)' does not exist but it seems unrelated
  • fixed some tests cases in test_functional.py

Signed-off-by: Natalia Piekarz <janikn67@gmail.com>
Signed-off-by: Natalia Piekarz <janikn67@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant