-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple scheme security requirement should be allowed #108
Labels
Comments
@jormaechea Thanks for pointing this out - this does look like a mistake. To answer your question, yes, we are happy to review PRs so feel free to open one! |
@dpopp07 Great! I'll tackle it this week and get back to you! |
jormaechea
added a commit
to jormaechea/openapi-validator
that referenced
this issue
Oct 4, 2019
Multiple security schemes are now considered as valid and flagged as used Fixes IBM#108
dpopp07
pushed a commit
that referenced
this issue
Oct 4, 2019
* Multiple security schemes are now considered as valid and flagged as used * Fixes #108
🎉 This issue has been resolved in version 0.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
openapi-validator/src/plugins/validation/2and3/semantic-validators/security-ibm.js
Lines 60 to 75 in 0c0b39c
According to the standard:
You're checking that each Security Requirement Object contains only one scheme, and setting a non-configurable warning.
I suggest one of the following:
a) Remove this validation, because is non-standard.
b) Make it configurable so user can decide what to do with it.
Thanks.
PD: Are you reviewing PRs?
UPDATE
This should be also be fixed, because it only labels the first one as used.
openapi-validator/src/plugins/validation/2and3/semantic-validators/security-definitions-ibm.js
Lines 77 to 78 in f8cc2bd
The text was updated successfully, but these errors were encountered: