fix: Consider as valid multiple schemes in a security requirement object #109

jormaechea · 2019-10-04T14:51:12Z

Multiple security schemes are now considered as valid and flagged as used.
Added unit tests for the new code.

Fixes #108

Multiple security schemes are now considered as valid and flagged as used Fixes IBM#108

CLAassistant · 2019-10-04T14:51:31Z

All committers have signed the CLA.

codecov · 2019-10-04T14:52:47Z

Codecov Report

Merging #109 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   92.32%   92.37%   +0.04%     
==========================================
  Files          55       55              
  Lines        1941     1940       -1     
==========================================
  Hits         1792     1792              
+ Misses        149      148       -1

Impacted Files	Coverage Δ
...lidation/2and3/semantic-validators/security-ibm.js	`100% <100%> (+1.81%)`	⬆️
...d3/semantic-validators/security-definitions-ibm.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80f556a...4501f19. Read the comment docs.

jormaechea · 2019-10-04T15:14:20Z

This is ready for review!

dpopp07

Looks good 👍

Thanks for the PR!

## [0.15.1](v0.15.0...v0.15.1) (2019-10-04) ### Bug Fixes * allow multiple schemes in a security requirement object ([#109](#109)) ([f02ef2b](f02ef2b)), closes [#108](#108)

dpopp07 · 2019-10-04T16:54:10Z

🎉 This PR is included in version 0.15.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

fix: Consider as valid multiple schemes in a security requirement object

4501f19

Multiple security schemes are now considered as valid and flagged as used Fixes IBM#108

dpopp07 self-requested a review October 4, 2019 16:43

dpopp07 approved these changes Oct 4, 2019

View reviewed changes

dpopp07 merged commit f02ef2b into IBM:master Oct 4, 2019

dpopp07 pushed a commit that referenced this pull request Oct 4, 2019

chore(release): 0.15.1 [skip ci]

79de6e7

## [0.15.1](v0.15.0...v0.15.1) (2019-10-04) ### Bug Fixes * allow multiple schemes in a security requirement object ([#109](#109)) ([f02ef2b](f02ef2b)), closes [#108](#108)

dpopp07 added the released label Oct 4, 2019

jormaechea deleted the Issue-108-Multiple-security-schemes-validation branch June 20, 2020 19:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Consider as valid multiple schemes in a security requirement object #109

fix: Consider as valid multiple schemes in a security requirement object #109

jormaechea commented Oct 4, 2019

CLAassistant commented Oct 4, 2019 •

edited

codecov bot commented Oct 4, 2019

jormaechea commented Oct 4, 2019

dpopp07 left a comment

dpopp07 commented Oct 4, 2019

fix: Consider as valid multiple schemes in a security requirement object #109

fix: Consider as valid multiple schemes in a security requirement object #109

Conversation

jormaechea commented Oct 4, 2019

CLAassistant commented Oct 4, 2019 • edited

codecov bot commented Oct 4, 2019

Codecov Report

jormaechea commented Oct 4, 2019

dpopp07 left a comment

Choose a reason for hiding this comment

dpopp07 commented Oct 4, 2019

CLAassistant commented Oct 4, 2019 •

edited