feat: added configurable warning limits through .thresholdrc file #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barrett-schonefeld
force-pushed
the
limits
branch
from
152aed4
to
8276011
Compare
barrett-schonefeld
changed the title
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
=========================================
Coverage ? 92.84%
=========================================
Files ? 56
Lines ? 2109
Branches ? 0
=========================================
Hits ? 1958
Misses ? 151
Partials ? 0
Continue to review full report at Codecov.
|
barrett-schonefeld
force-pushed
the
limits
branch
from
8276011
to
8580597
Compare
|
Added @danhudlow to evaluate if this solution works for VPC. |
mkistler
suggested changes
Feb 7, 2020
barrett-schonefeld
force-pushed
the
limits
branch
from
8580597
to
5cc6bd1
Compare
barrett-schonefeld
force-pushed
the
limits
branch
from
5cc6bd1
to
dbe78c6
Compare
dpopp07
requested changes
Feb 7, 2020
barrett-schonefeld
force-pushed
the
limits
branch
from
dbe78c6
to
2c5869f
Compare
barrett-schonefeld
force-pushed
the
limits
branch
2 times, most recently
from
a09defa
to
78cee67
Compare
barrett-schonefeld
force-pushed
the
limits
branch
3 times, most recently
from
139ee86
to
9f1c421
Compare
- added code to process a .thresholdrc file to get warnings limit - used warning limit to set exit code to 1 and print a message if warning limit is exceeded - added validation on the user input from .thresholdrc to check if valid keys and values provided in .thresholdrc - set default limit to Number.MAX_VALUE if no .thresholdrc provided - added tests to test error handling for .thresholdrc file and expected output when warning limits exceeded - added test to check if error thrown when invalid JSON provided in .thresholdrc - refactored error printing in processConfiguration file into a printConfigErrors function - ran npm run fix to fix style - documented how to add a warnings limit in the README
barrett-schonefeld
force-pushed
the
limits
branch
from
9f1c421
to
21edbfc
Compare
dpopp07
pushed a commit
that referenced
this pull request
Feb 10, 2020
# [0.19.0](v0.18.0...v0.19.0) (2020-02-10) ### Features * added configurable warning limits through .thresholdrc file ([#132](#132)) ([2c3a919](2c3a919))
|
🎉 This PR is included in version 0.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Current user contract:
lint-openapicommand.Example output:
Error handling in .thresholdrc file
Warning limit exceeded message