Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added configurable warning limits through .thresholdrc file #132

Merged
merged 1 commit into from
Feb 10, 2020
Merged

feat: added configurable warning limits through .thresholdrc file #132

merged 1 commit into from
Feb 10, 2020
+276 −19

Commits on Feb 10, 2020

  1. feat: added configurable warning limits through .thresholdrc file 

    - added code to process a .thresholdrc file to get warnings limit
- used warning limit to set exit code to 1 and print a message if warning limit is exceeded
- added validation on the user input from .thresholdrc to check if valid keys and values provided in .thresholdrc
- set default limit to Number.MAX_VALUE if no .thresholdrc provided
- added tests to test error handling for .thresholdrc file and expected output when warning limits exceeded
- added test to check if error thrown when invalid JSON provided in .thresholdrc
- refactored error printing in processConfiguration file into a printConfigErrors function
- ran npm run fix to fix style
- documented how to add a warnings limit in the README
    Barrett Schonefeld committed Feb 10, 2020
    Configuration menu
    Copy the full SHA
    21edbfc View commit details
    Browse the repository at this point in the history