Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include the validator version in the JSON output #256

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

barrett-schonefeld
Copy link
Contributor

Changes:

  • Get the validator version from package.json and include it in the json output
  • Update package.json and package-lock.json to resolve differences in Spectral versions now

Tests:

  • Update tests to match latest Spectral behavior

Copy link
Contributor

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good but I'd like to see a test that verifies that the version is included in the JSON output.

@barrett-schonefeld barrett-schonefeld force-pushed the include-validator-version-in-json-output branch from 9ba3251 to 42b1e9c Compare March 4, 2021 15:34
@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #256 (073e868) into main (c75bff0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@     Coverage Diff     @@
##   main   #256   +/-   ##
===========================
===========================

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c75bff0...0aac44c. Read the comment docs.

Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pretty much looks good as is, only requesting changes to verify that the CLI validator is in fact returning an exit code when JSON output is turned on

test/cli-validator/tests/expected-output.test.js Outdated Show resolved Hide resolved
@barrett-schonefeld barrett-schonefeld force-pushed the include-validator-version-in-json-output branch from 42b1e9c to c7b2ac6 Compare March 5, 2021 18:25
Copy link
Member

@dpopp07 dpopp07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@barrett-schonefeld barrett-schonefeld force-pushed the include-validator-version-in-json-output branch from c7b2ac6 to c237a1a Compare March 5, 2021 19:25
Changes:
- Get the validator version from `package.json` and include it in the json output
- Update package.json and package-lock.json to resolve differences in Spectral versions now

Test:
- Ensure json output includes validator version
@barrett-schonefeld barrett-schonefeld force-pushed the include-validator-version-in-json-output branch from c237a1a to 0aac44c Compare March 5, 2021 21:26
Copy link
Contributor

@mkistler mkistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@barrett-schonefeld barrett-schonefeld merged commit 6442a0b into main Mar 5, 2021
@barrett-schonefeld barrett-schonefeld deleted the include-validator-version-in-json-output branch March 5, 2021 22:31
dpopp07 pushed a commit that referenced this pull request Mar 5, 2021
# [0.35.0](v0.34.4...v0.35.0) (2021-03-05)

### Features

* include the validator version in the JSON output ([#256](#256)) ([6442a0b](6442a0b))
@dpopp07
Copy link
Member

dpopp07 commented Mar 5, 2021

🎉 This PR is included in version 0.35.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants