-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: include the validator version in the JSON output #256
feat: include the validator version in the JSON output #256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good but I'd like to see a test that verifies that the version is included in the JSON output.
9ba3251
to
42b1e9c
Compare
Codecov Report
@@ Coverage Diff @@
## main #256 +/- ##
===========================
===========================
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pretty much looks good as is, only requesting changes to verify that the CLI validator is in fact returning an exit code when JSON output is turned on
42b1e9c
to
c7b2ac6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
c7b2ac6
to
c237a1a
Compare
Changes: - Get the validator version from `package.json` and include it in the json output - Update package.json and package-lock.json to resolve differences in Spectral versions now Test: - Ensure json output includes validator version
c237a1a
to
0aac44c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
# [0.35.0](v0.34.4...v0.35.0) (2021-03-05) ### Features * include the validator version in the JSON output ([#256](#256)) ([6442a0b](6442a0b))
🎉 This PR is included in version 0.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes:
package.json
and include it in the json outputpackage.json
andpackage-lock.json
to resolve differences in Spectral versions nowTests: