-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: flag definitions that are defined but never used #144
Conversation
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 92.86% 92.88% +0.02%
==========================================
Files 61 61
Lines 2103 2109 +6
==========================================
+ Hits 1953 1959 +6
Misses 150 150 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - your approach is simple enough that we can take advantage and validate refs for all fields under components, so we might as well
- added checks for parameters, responses, and all other components object types defined in the components section that are not used in the API definition - added tests to that ensure that a warning is issued when a response or parameter definition is not used - added tests to ensure a warning is not issued when a response or parameter definition is used - updated comments in refs.js - restructured refs.js as needed to support checking components.parameters and components.responses
cea4817
to
a68dbae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
# [0.22.0](v0.21.0...v0.22.0) (2020-02-21) ### Features * flag definitions that are defined but never used ([#144](#144)) ([a131408](a131408))
🎉 This PR is included in version 0.22.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Changes:
Tests: