fix: dont validate schema properties called 'responses' as responses #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkistler
approved these changes
Sep 2, 2020
dpopp07
force-pushed
the
dp/responses-false-positive
branch
from
fd07e14
to
c8a32e6
Compare
dpopp07
pushed a commit
that referenced
this pull request
Sep 2, 2020
## [0.29.3](v0.29.2...v0.29.3) (2020-09-02) ### Bug Fixes * dont validate schema properties called 'responses' as responses ([#194](#194)) ([4277079](4277079))
|
🎉 This PR is included in version 0.29.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the only way we checked for a response object was by checking for the string "responses" in the path at a certain location. This would cause schema properties named
responsesto be validated as if it were a response. This would cause confusing warnings/errors.This PR introduces robust logic to prove that the object in question is in fact, a response.
Additionally, I fixed some linting issues and added a linting step to the Travis build so that these things won't go uncaught in the future.
Resolves #188