-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: validate x-sdk-operations extension #268
Conversation
c83e1e2
to
92faa49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Left one comment on the README and we probably want to let Mike have a look at the schema before merging
Changes: - add custom Spectral rule to validate x-sdk-operations - add custom Spectral function to invoke ajv JSON Schema validator on x-sdk-operations JSON Schema Tests: - ensure warnings issued for invalid x-sdk-operations schema Docs: - document `ibm-sdk-operations` rule
92faa49
to
6a49b38
Compare
94f0ed6
to
7f8b3cf
Compare
7f8b3cf
to
7dff978
Compare
7dff978
to
94bc958
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looks good to me 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
# [0.40.0](v0.39.0...v0.40.0) (2021-04-06) ### Features * validate x-sdk-operations extension ([#268](#268)) ([b025eac](b025eac))
🎉 This PR is included in version 0.40.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Purpose:
x-sdk-operations
extension are good, so they may be utilized properly by tooling that usesx-sdk-operations
Changes:
x-sdk-operations
Tests:
Docs:
ibm-sdk-operations
rule