Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cert-manager support #59

Closed
kfox1111 opened this issue Apr 17, 2019 · 4 comments · Fixed by #147
Closed

cert-manager support #59

kfox1111 opened this issue Apr 17, 2019 · 4 comments · Fixed by #147

Comments

@kfox1111
Copy link

Instead of generating the certificates out of band, then injecting them, it would be nice if the helm chart supported asking cert-manager to do that automatically.

Cert-manager even uses this mechanism to register its own webhook. For example, see:
https://github.com/jetstack/cert-manager/blob/master/deploy/charts/cert-manager/webhook/templates/pki.yaml
@josephdrichard josephdrichard mentioned this issue Jul 9, 2020
Closed
@josephdrichard
Copy link
Contributor

By changing the certificate names to those used by portieris, it is very straightforward to use certificates from cert-manager.

@josephdrichard josephdrichard mentioned this issue Jul 9, 2020
Merged
@sjhx
Copy link
Member

sjhx commented Jul 13, 2020

Thankyou for this contribution, would you also be able to submit a PR to keep it inline?

@josephdrichard
Copy link
Contributor

Thankyou for this contribution, would you also be able to submit a PR to keep it inline?

What are you referring to doing inline?

@sjhx
Copy link
Member

sjhx commented Jul 14, 2020 •
edited
Loading

Sorry I seem to have left out some important words!
I was intending to ask if you could update the README.md to describe what the options are for getting certificates in place when installing, README.md seems to have gone out of sync with the code.

@sjhx sjhx linked a pull request Jul 15, 2020 that will close this issue
Use cert-manager naming convention for portieris #147
Merged
starlingx-github pushed a commit to starlingx/portieris-armada-app that referenced this issue Jul 23, 2020
@josephdrichard
Patch in fixes for blocking portieris issues
5a89ba7 
Specifically, these two issues are blocking using portieris app with
starlingx:
 * IBM/portieris#51
 * IBM/portieris#59

Once these fixes are included in a published release of portieris,
drop this patch and rebase to the latest release.

Story: 2007348
Task: 40434
Change-Id: I14d0e5664333c5080440b9fd156c66a317444563
Signed-off-by: Joseph Richard <joseph.richard@windriver.com>
@sjhx sjhx closed this as completed in #147 Aug 19, 2020
sjhx added a commit that referenced this issue Aug 19, 2020
@josephdrichard @sjhx
Use cert-manager naming convention for portieris (#147)
850f87d 
* Use cert-manager naming convention for portieris

Rename portieris certs from serverCert.pem and serverKey.pem to tls.crt
and tls.key, following the naming conventions used by cert-manager.
In combination with SkipSecretCreation=true, this allows using
cert-manager to generate portieris certs.

#59

Signed-off-by: Joseph Richard <joseph.richard@windriver.com>

* Add UseCertManager option to get CA certificate

This commit adds an option in the admission webhook, to support getting
the CA certificate through injection from the cert-manager webhook,
instead of being passed into the helm chart as a file.

#59

Signed-off-by: Joseph Richard <joseph.richard@windriver.com>

* Create certificate by default if UseCertManager

#59

Signed-off-by: Joseph Richard <joseph.richard@windriver.com>

* Add optionally using cert-manager to readme

#59

Signed-off-by: Joseph Richard <joseph.richard@windriver.com>

Co-authored-by: Stuart Hayton <sjhx@users.noreply.github.com>
tim-gp pushed a commit to tim-gp/portieris that referenced this issue Oct 1, 2020
@josephdrichard @sjhx
Use cert-manager naming convention for portieris (IBM#147)
1d3736c 
* Use cert-manager naming convention for portieris

Rename portieris certs from serverCert.pem and serverKey.pem to tls.crt
and tls.key, following the naming conventions used by cert-manager.
In combination with SkipSecretCreation=true, this allows using
cert-manager to generate portieris certs.

IBM#59

Signed-off-by: Joseph Richard <joseph.richard@windriver.com>

* Add UseCertManager option to get CA certificate

This commit adds an option in the admission webhook, to support getting
the CA certificate through injection from the cert-manager webhook,
instead of being passed into the helm chart as a file.

IBM#59

Signed-off-by: Joseph Richard <joseph.richard@windriver.com>

* Create certificate by default if UseCertManager

IBM#59

Signed-off-by: Joseph Richard <joseph.richard@windriver.com>

* Add optionally using cert-manager to readme

IBM#59

Signed-off-by: Joseph Richard <joseph.richard@windriver.com>

Co-authored-by: Stuart Hayton <sjhx@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use cert-manager naming convention for portieris
3 participants
@kfox1111 @sjhx @josephdrichard