Support Helm3 and OpenShift #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molepigeon
requested changes
Jun 18, 2020
| type: RunAsAny | ||
| groups: | ||
| - system:cluster-admins | ||
| kind: SecurityContextConstraints |
There was a problem hiding this comment.
Just for readability, could apiVersion, kind, and metadata be moved to the top of this file please? It took me a while to realise this file had those fields. Alphabetical is fine for the other fields.
molepigeon
approved these changes
Jun 18, 2020
tim-gp
pushed a commit
to tim-gp/portieris
that referenced
this pull request
Oct 1, 2020
* Adjust helm hook annotations and add patch to clusterrole. * Add security context constraint for OpenShift. * Update readme with Helm3 support * Adjust scc field ordering for better readability. Co-authored-by: Jeffrey Hoekman <jeffrey.hoekman@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enhancement adds support for OpenShift and Helm3. To support Helm3 adjustments were made to hook annotations so that resources are applied in proper order during creation and deletion. In addition, in order to successfully install the image/cluster image policies, the
patchverb was added in the cluster role resource for apiGroupsecurityenforcement.admission.cloud.ibm.com.To support OpenShift a security context contraint was added for the
portierisservice account. Thissccmust be in place prior to instantiating the deployment, so the helmpre-installhook annotation was utilized.Closes: #127
Closes: #124