WIP: Split trust endpoint #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d modified use of access token in the absence of token
…value of www-authenticate header - referred to https://github.com/docker/distribution/blob/master/registry/client/auth/challenge/authchallenge.go#L144
…rom www authenticate header
…here anything other 200 or 401 is returned
…ockerconfig file - Portieris will rely on the environment variables for default fallback
…g the value is invalid
Use the upstream package instead of copying in files
|
Looks like this crosses with my fix to helpers/image/image.go, if my PR goes first you will need to merge, sorry! |
This was referenced Jun 22, 2020
Closed
|
I don't think there is intent to pursue this PR - will close. |
|
Sorry, dropped the ball on this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to resolve the issues with the hard-coded endpoint issues mentioned in #51
PR is heavily based on the work in #63 by @jerrinss5