DSANSIBLE-78 #21
Merged
DSANSIBLE-78 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to Support Win 1) change hard coded path separator to os.sep Signed-off-by: shipeng@us.ibm.com <shipeng@us.ibm.com>
AnboAnbo
force-pushed
the
b_78_support_win
branch
from
ce66f66
to
b5dec30
Compare
added 2 commits
July 11, 2022 16:02
to Support Win 1) change hard coded path separator to os.sep Signed-off-by: shipeng@us.ibm.com <shipeng@us.ibm.com>
…pport_win Signed-off-by: shipeng@us.ibm.com <shipeng@us.ibm.com>
AnboAnbo
force-pushed
the
b_78_support_win
branch
from
b26d97e
to
4e0b33f
Compare
blearandy
approved these changes
Jul 12, 2022
blearandy
added a commit
that referenced
this pull request
Sep 29, 2022
* Feature/dsansible 76/setup read the docs (#17) * Update the README to point to read the docs, and add in other readme items likes additional badges * Feature/dsansible 76/setup read the docs (#19) * Update the README to point to read the docs, and add in other readme items likes additional badges * A few additional README.md changes * Upating per Justin's comments * Add the read the docs theme to the pyds8k documentation. * Trying to get read the docs theme to work. * removing import... * code to handle theme only when on readthedocs * code to handle theme only when on readthedocs * code to handle theme only when on readthedocs * add two function to pyds8k (#12) * Revert "add two function to pyds8k (#12)" (#22) This reverts commit eb97922. * To incorporate the PR - #12 (#24) (task/CSI-2929 add two function to pyds8k), by manually adding following function only: get_host_ports_by_host Signed-off-by: shipeng@us.ibm.com <shipeng@us.ibm.com> Co-authored-by: shipeng@us.ibm.com <shipeng@us.ibm.com> * DSANSIBLE-78 (#21) * DSANSIBLE-78 to Support Win 1) change hard coded path separator to os.sep Signed-off-by: shipeng@us.ibm.com <shipeng@us.ibm.com> * DSANSIBLE-78 to Support Win 1) change hard coded path separator to os.sep Signed-off-by: shipeng@us.ibm.com <shipeng@us.ibm.com> Co-authored-by: shipeng@us.ibm.com <shipeng@us.ibm.com> * DSANSIBLE-28, supporting creating with id & ids (#20) * DSANSIBLE-28, supporting creating with id & ids Signed-off-by: shipeng@us.ibm.com <shipeng@us.ibm.com> * DSANSIBLE-28, supporting creating with id & ids(reformat, flake8 compliance) Signed-off-by: shipeng@us.ibm.com <shipeng@us.ibm.com> Co-authored-by: shipeng@us.ibm.com <shipeng@us.ibm.com> * DSANSIBLE-98 Migrate to pytest (#25) * DSANSIBLE-98 Migrate to pytest nose is unmaintained and doesn't work with >python3.9 Convert to pytest Add python3.9 and 3.10 Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * Add python 3.9 and 3.10 to travis Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * DSANSIBLE-98 Relax pytest version for 3.6 Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * DSANSIBLE-98 Run cover,docs,flake8 on 3.9 cover and py3x are the same, no need to duplicate Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * DSANSIBLE-78 Add windows to CI (#26) Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * added create_alias_volumes call in RootVolumeMixin for alias support (#27) * added create_alias_volumes call in RootVolumeMixin for alias support Signed-off-by: Randy Blea <blead@us.ibm.com> * fix line too long error Signed-off-by: Randy Blea <blead@us.ibm.com> * DSANSIBLE-83 Add unit test for creating alias vols Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> Co-authored-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * DSANSIBLE-87 Add resource groups. (#30) * DSANSIBLE-87 Add resource groups. Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * DSANSIBLE-87 fix incorrect variable name. Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * DSANSIBLE-102: add basevolume parser on volume alias request (#31) Signed-off-by: shipeng@us.ibm.com Signed-off-by: shipeng@us.ibm.com Co-authored-by: shipeng@us.ibm.com <shipeng@us.ibm.com> * DSANSIBLE-100: flash copy information was not correctly handled due to evolving flash copy rest api. (#32) instead of *_flashcopy, *_cs_flashcopy should be used for flashcopy operations for backward compatibility, move to use volume_id for pre-R8, which is deprecated. if volume_id is empty and the calling party is a volume, volume_id is populated. Co-authored-by: shipeng@us.ibm.com <shipeng@us.ibm.com> Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> Signed-off-by: shipeng@us.ibm.com Co-authored-by: Matan Carmeli <45543087+matancarmeli7@users.noreply.github.com> Co-authored-by: shipeng <AnboAnbo@users.noreply.github.com> Co-authored-by: shipeng@us.ibm.com <shipeng@us.ibm.com> Co-authored-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com>
blearandy
added a commit
that referenced
this pull request
Sep 29, 2022
* Feature/dsansible 76/setup read the docs (#17) * Update the README to point to read the docs, and add in other readme items likes additional badges * Feature/dsansible 76/setup read the docs (#19) * Update the README to point to read the docs, and add in other readme items likes additional badges * A few additional README.md changes * Upating per Justin's comments * Add the read the docs theme to the pyds8k documentation. * Trying to get read the docs theme to work. * removing import... * code to handle theme only when on readthedocs * code to handle theme only when on readthedocs * code to handle theme only when on readthedocs * add two function to pyds8k (#12) * Revert "add two function to pyds8k (#12)" (#22) This reverts commit eb97922. * To incorporate the PR - #12 (#24) (task/CSI-2929 add two function to pyds8k), by manually adding following function only: get_host_ports_by_host Signed-off-by: shipeng@us.ibm.com <shipeng@us.ibm.com> Co-authored-by: shipeng@us.ibm.com <shipeng@us.ibm.com> * DSANSIBLE-78 (#21) * DSANSIBLE-78 to Support Win 1) change hard coded path separator to os.sep Signed-off-by: shipeng@us.ibm.com <shipeng@us.ibm.com> * DSANSIBLE-78 to Support Win 1) change hard coded path separator to os.sep Signed-off-by: shipeng@us.ibm.com <shipeng@us.ibm.com> Co-authored-by: shipeng@us.ibm.com <shipeng@us.ibm.com> * DSANSIBLE-28, supporting creating with id & ids (#20) * DSANSIBLE-28, supporting creating with id & ids Signed-off-by: shipeng@us.ibm.com <shipeng@us.ibm.com> * DSANSIBLE-28, supporting creating with id & ids(reformat, flake8 compliance) Signed-off-by: shipeng@us.ibm.com <shipeng@us.ibm.com> Co-authored-by: shipeng@us.ibm.com <shipeng@us.ibm.com> * DSANSIBLE-98 Migrate to pytest (#25) * DSANSIBLE-98 Migrate to pytest nose is unmaintained and doesn't work with >python3.9 Convert to pytest Add python3.9 and 3.10 Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * Add python 3.9 and 3.10 to travis Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * DSANSIBLE-98 Relax pytest version for 3.6 Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * DSANSIBLE-98 Run cover,docs,flake8 on 3.9 cover and py3x are the same, no need to duplicate Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * DSANSIBLE-78 Add windows to CI (#26) Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * added create_alias_volumes call in RootVolumeMixin for alias support (#27) * added create_alias_volumes call in RootVolumeMixin for alias support Signed-off-by: Randy Blea <blead@us.ibm.com> * fix line too long error Signed-off-by: Randy Blea <blead@us.ibm.com> * DSANSIBLE-83 Add unit test for creating alias vols Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> Co-authored-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * DSANSIBLE-87 Add resource groups. (#30) * DSANSIBLE-87 Add resource groups. Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * DSANSIBLE-87 fix incorrect variable name. Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> * DSANSIBLE-102: add basevolume parser on volume alias request (#31) Signed-off-by: shipeng@us.ibm.com Signed-off-by: shipeng@us.ibm.com Co-authored-by: shipeng@us.ibm.com <shipeng@us.ibm.com> * DSANSIBLE-100: flash copy information was not correctly handled due to evolving flash copy rest api. (#32) instead of *_flashcopy, *_cs_flashcopy should be used for flashcopy operations for backward compatibility, move to use volume_id for pre-R8, which is deprecated. if volume_id is empty and the calling party is a volume, volume_id is populated. Co-authored-by: shipeng@us.ibm.com <shipeng@us.ibm.com> * Update __init__.py (#34) Update release number for pyds8k Signed-off-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com> Signed-off-by: shipeng@us.ibm.com Co-authored-by: Matan Carmeli <45543087+matancarmeli7@users.noreply.github.com> Co-authored-by: shipeng <AnboAnbo@users.noreply.github.com> Co-authored-by: shipeng@us.ibm.com <shipeng@us.ibm.com> Co-authored-by: NjM3MjY5NzAgNzA3MzA3 <102704081+NjM3MjY5NzAgNzA3MzA3@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to Support Win
2) add osx, windows into .travis.ymltravisci does not support python on windows yet.
Signed-off-by: shipeng@us.ibm.com shipeng@us.ibm.com