fix(retries): change default retry_interval to 1 second (was 0.1) #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the default value of the retry_interval parameter (in the BaseService.enable_retries method) from 0.1 to 1.0. This will result in default retry intervals of 1, 2, 4, 8, ... seconds instead of 0.1, 0.2, 0.4, 0.8, ... seconds. This change will align the python core retry support with Go. Also added some detailed info in the docstring for the method as well.
Codecov Report
@@ Coverage Diff @@
## main #122 +/- ##
=======================================
Coverage 99.50% 99.50%
=======================================
Files 22 22
Lines 815 815
=======================================
Hits 811 811
Misses 4 4
Continue to review full report at Codecov.
|
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Aug 20, 2021
## [3.11.2](v3.11.1...v3.11.2) (2021-08-20) ### Bug Fixes * **retries:** change default retry_interval to 1 second (was 0.1) ([#122](#122)) ([3daef00](3daef00))
|
🎉 This PR is included in version 3.11.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the default value of the retry_interval
parameter (in the BaseService.enable_retries method) from 0.1
to 1.0. This will result in default retry intervals
of 1, 2, 4, 8, ... seconds instead of 0.1, 0.2, 0.4, 0.8, ... seconds.
This change will align the python core retry support with Go.
Also added some detailed info in the docstring for the method as well.