-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set minimum TLS version to v1.2 #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We just need to make really sure that this will also work with retries enabled.
Edit: I think we need to also test these changes with a couple of integration tests within the platform-services python SDK just to make sure that these changes work correctly with some actual IBM Cloud services.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I validated that mounting the SSLHTTPAdapter for http
as well as https
doesn't seem to cause any problems. LGTM I have just one question arond the SSL context, but that's more for my understanding than any impediment to merging this.
## [3.15.1](v3.15.0...v3.15.1) (2022-03-21) ### Bug Fixes * set minimum TLS version to v1.2 ([#139](#139)) ([8d6ec4b](8d6ec4b))
🎉 This PR is included in version 3.15.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR introduces a custom HTTP adapter that wraps the original one
and adds SSL context, that sets the minimum TLS version required to v1.2.