Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new sarama use pierrec/lz4 , V 1.18.0 use which pierrec/lz4? #1292

Closed
h00401342 opened this issue Feb 25, 2019 · 2 comments · Fixed by #1469
Closed

new sarama use pierrec/lz4 , V 1.18.0 use which pierrec/lz4? #1292

h00401342 opened this issue Feb 25, 2019 · 2 comments · Fixed by #1469

Comments

@h00401342
Copy link

Versions

Please specify real version numbers or git SHAs, not just "Latest" since that changes fairly regularly.
Sarama Version:
Kafka Version:
Go Version:

Configuration

What configuration values are you using for Sarama and Kafka?

Logs

When filing an issue please provide logs from Sarama and Kafka if at all
possible. You can set sarama.Logger to a log.Logger to capture Sarama debug
output.

Problem Description
@varun06
Copy link
Contributor

varun06 commented Feb 26, 2019

Can you please elaborate more?

@d1egoaz
Copy link
Contributor

d1egoaz commented Aug 22, 2019

@h00401342 not sure if the thing you're trying to mention is that we are using a non versioned dependency to the lz4 lib?

as currently go.mod is referencing a commit for lz4:

github.com/pierrec/lz4 v0.0.0-20190327172049-315a67e90e41

I think we could add a reference to a released version, however the lz4 repo doesn't use go mod, but at least, it's tagging the releases.

Something like:

github.com/pierrec/lz4 v2.2.6+incompatible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants