You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Honestly, not sure what can realistically be done about it in sarama, removing deadlines does not sound like viable solution. Still thought I will share my findings.
The text was updated successfully, but these errors were encountered:
Thank you for taking the time to raise this issue. However, it has not had any activity on it in the past 90 days and will be closed in 30 days if no updates occur.
Please check if the master branch has already resolved the issue since it was raised. If you believe the issue is still valid and you would like input from the maintainers then please comment to ask for it to be reviewed.
ghost
added
the
stale
Issues and pull requests without any recent activity
label
Mar 16, 2021
Versions
Configuration
Really the important part is TLS Enabled, i.e.
Logs
Again, the relevant part is this log.
Problem Description
After enabling TLS, the above error happens on client
Close()
call. Without TLS, everything works fine.I went down to it and figured that the culprit is https://github.com/Shopify/sarama/blob/0189d59e5253ee7aa2a9eb50bffd18a69460630d/broker.go#L309
but that's probably because it's the first write executed on the connection?
Going further, I found out that removing deadline from https://github.com/Shopify/sarama/blob/0189d59e5253ee7aa2a9eb50bffd18a69460630d/broker.go#L708
(or setting it to
time.Time{}
) removes the problem.Then I found this report golang/go#13828 stating that
SetWriteDeadline
does not seem to work properly on TLS Clients. Which appears to be (still) true.Honestly, not sure what can realistically be done about it in
sarama
, removing deadlines does not sound like viable solution. Still thought I will share my findings.The text was updated successfully, but these errors were encountered: