Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: protocol support for V11 fetch w/ rackID #1605

Merged
merged 1 commit into from Feb 11, 2020
Merged

feat: protocol support for V11 fetch w/ rackID #1605

merged 1 commit into from Feb 11, 2020

Conversation

dnwe
Copy link
Collaborator

@dnwe dnwe commented Feb 6, 2020

These are the initial protocol beginnings to add support for follower
fetching (KIP-392). This commit simply adds configuration support for a
consumer to specify its rack identifier and to flow it in a V11
FetchRequest and correctly decode the "preferredReplica" field in the
response. Currently no further action is taken. A future PR will be
required to act upon this response.

These are the initial protocol beginnings to add support for follower
fetching (KIP-392). This commit simply adds configuration support for a
consumer to specify its rack identifier and to flow it in a V11
FetchRequest and correctly decode the "preferredReplica" field in the
response. Currently no further action is taken. A future PR will be
required to act upon this response.

Signed-off-by: Dominic Evans <dominic.evans@uk.ibm.com>
@dnwe dnwe requested a review from bai as a code owner February 6, 2020 22:27
@lizthegrey
Copy link
Contributor

ooh, this is super exciting!

@bai
Copy link
Contributor

bai commented Feb 11, 2020

👋 @dnwe you should have received an invite to join this repo as a collaborator so you could merge this PR and others that you see fit. Thank you so much for continued contributions.

@dnwe
Copy link
Collaborator Author

dnwe commented Feb 11, 2020

@bai thanks 😀

As an aside, I have also been experimenting with generating the protocol Go code from the upstream .json-based format descriptions, which I thought might be interesting for Sarama v2.x — once I have something reasonable around that I'll push up a branch to collaborate over

@dnwe dnwe merged commit 4ba4c2f into IBM:master Feb 11, 2020
@dnwe dnwe deleted the fetch-v11-protocol branch February 11, 2020 13:52
@lizthegrey
Copy link
Contributor

@dnwe when you do decide to work on the followup to read PreferredReadReplica values for fetch purposes, let me know and I'd be happy to collaborate or test, I just don't know this particular codebase well enough to wire together without help :)

@dneralla
Copy link
Contributor

@lizthegrey @dnwe I took a shot at that #1696
can you guys take a look ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants