Handle isolation level in Offset(Request|Response) and require stable offset in FetchOffset(Request|Response) #1929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
celrenheit
force-pushed
the
fetch-offset-require-stable-offset
branch
from
1500bf1
to
3f98e25
Compare
celrenheit
commented
Apr 29, 2021
celrenheit
force-pushed
the
fetch-offset-require-stable-offset
branch
2 times, most recently
from
f4db789
to
c5e3fdd
Compare
dnwe
reviewed
Apr 29, 2021
There was a problem hiding this comment.
Thank you for your contribution, I eyeballed the protocol changes against the protocol specs and the version matrix and the changes look good to me
It enables list available offset (OffsetRequest and OffsetResponse) to require read committed isolation level. It adds RequireStable field to FetchOffsetRequest.
celrenheit
force-pushed
the
fetch-offset-require-stable-offset
branch
from
c5e3fdd
to
fce917a
Compare
dnwe
approved these changes
Apr 29, 2021
|
I've rebased it on master so that it can pass the 2.8.0 test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables OffsetRequest and to require read committed isolation.
It adds RequireStable field to FetchOffsetRequest, this requires the use of the new compact protocol present in version 6+.