fix: explicitly use uint64 for payload length #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested with: ``` docker run --platform=linux/i386 --rm -v "$PWD":/usr/src -w /usr/src golang:1.16 go build -v ``` Fixes #1943
ghost
added
the
Closed
aaronbee
reviewed
May 21, 2021
gssapi_kerberos.go
Outdated
| @@ -57,7 +57,7 @@ type KerberosClient interface { | |||
|
|
|||
| // writePackage appends length in big endian before the payload, and sends it to kafka | |||
| func (krbAuth *GSSAPIKerberosAuth) writePackage(broker *Broker, payload []byte) (int, error) { | |||
| length := len(payload) | |||
| length := uint64(len(payload)) | |||
| size := length + 4 // 4 byte length header + payload | |||
| if size > math.MaxUint32 { | |||
There was a problem hiding this comment.
You might want to change this to size > math.MaxInt32 rather than MaxUint32. Line 65 would panic on a 32-bit system if size is > math.MaxInt32. But, you are kinda asking for it if you are trying to write > 2GB of data all at once.
There was a problem hiding this comment.
I signed the CLA, btw, but can't comment on the PR for some reason. (Not sure I really needed to be the owner of such a small change :D, but thanks for including me.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with:
Fixes #1943