fix(test): make it simpler to re-use toxiproxy #2122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes it is convenient to re-use the docker containers between runs of an FV test. The existing support for supplying a pre-existing TOXIPROXY_ADDR was a little flakey. Tidy up functional_test.go so that it will getOrCreate the toxiproxy routes to the kafka brokers. Then you can just manually `docker-compose up -d` before running a given test yourself and prevent the teardown at the end. This is particularly useful for people who have migrated away from docker desktop to limavm and want to use `lima nerdctl compose` locally.
This was referenced Feb 1, 2022
This was referenced Apr 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes it is convenient to re-use the docker containers between runs of an FV test. The existing support for supplying a pre-existing TOXIPROXY_ADDR was a little flakey. Tidy up functional_test.go so that it will getOrCreate the toxiproxy routes to the kafka brokers. Then you can just manually
docker-compose up -dbefore running a given test yourself and prevent the teardown at the end.This is particularly useful for people who have migrated away from docker desktop to limavm and want to use
lima nerdctl composelocally.