Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci): bump golangci version, cleanup, depguard config #2504

Merged
merged 2 commits into from
Jul 17, 2023
Merged

chore(ci): bump golangci version, cleanup, depguard config #2504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0863085
chore(ci): bump golangci, remove deprecated linters
EladLeev Jul 17, 2023
da48ff2
chore(ci): add depguard config
EladLeev Jul 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
GOFLAGS: -tags=functional
uses: golangci/golangci-lint-action@v3
with:
version: v1.48.0
version: v1.53.3
test:
name: Unit Testing with Go ${{ matrix.go-version }}
runs-on: ubuntu-latest
Expand Down
15 changes: 11 additions & 4 deletions .golangci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ linters-settings:
misspell:
locale: US
goimports:
local-prefixes: github.com/Shopify/sarama
local-prefixes: github.com/IBM/sarama
gocritic:
enabled-tags:
- diagnostic
Expand All @@ -39,11 +39,18 @@ linters-settings:
lines: 300
statements: 300

depguard:
rules:
main:
deny:
- pkg: "io/ioutil"
desc: Use the "io" and "os" packages instead.

linters:
disable-all: true
enable:
- bodyclose
- deadcode
# - deadcode
- depguard
- exportloopref
- dogsled
Expand All @@ -68,12 +75,12 @@ linters:
# - paralleltest
# - scopelint
- staticcheck
- structcheck
# - structcheck
# - stylecheck
- typecheck
- unconvert
- unused
- varcheck
# - varcheck
- whitespace

issues:
Expand Down