Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sasl plain handshake #781

Closed
wants to merge 2 commits into from
Closed

Conversation

Alkorin
Copy link
Contributor

@Alkorin Alkorin commented Nov 7, 2016

This PR contains #748 + a bug fix.
#748 calls sendAndReceiveSASLPlainHandshake two times leading to a runtime error:

INFO[0008] client/metadata fetching metadata for all topics from broker ***:9093
INFO[0008] Successful SASL handshake
fatal error: runtime: out of memory

After removing the call in Open, everything works fine:

INFO[0002] client/metadata fetching metadata for all topics from broker ***:9093
INFO[0002] Successful SASL handshake
INFO[0002] SASL authentication successful with broker ***:9093:4 - [0 0 0 0]
INFO[0002] Connected to broker at ***:9093 (unregistered)
INFO[0002] client/brokers registered new broker #2 at ***:9093
INFO[0002] client/brokers registered new broker #5 at ***:9093
INFO[0002] client/brokers registered new broker #7 at ***:9093
INFO[0002] client/brokers registered new broker #1 at ***:9093
INFO[0002] client/brokers registered new broker #3 at ***:9093
INFO[0002] Successfully initialized new client

guillaumebreton and others added 2 commits November 7, 2016 13:20
This patch adds the mandatory SASL handshake for SASL negotiation.
@Alkorin
Copy link
Contributor Author

Alkorin commented Nov 21, 2016

Hi, any news ?
We would like to avoid having our own fork :/

@eapache
Copy link
Contributor

eapache commented Nov 22, 2016

Sorry for the delay on this. I manually rebased, tweaked and merged this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants