Only compress a message once #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. |
eapache
pushed a commit
that referenced
this pull request
Aug 22, 2013
Fixes #20. Pull request #8 introduced a bug where the flag indicating which compression format was used wouldn't be correctly set in the outgoing message. Instead of overriding the Value field (which would also be confusing for people trying to use it after sending) we cache the compressed payload in a separate hidden field, and don't change the compression flags. Add some tests to ensure this doesn't happen again. Bonus fix: error if we don't recognize the compression format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@burke @fw42
It occurred to me recently that due to the two-pass nature of message encoding, compressed messages were getting compressed twice when encoded, which was rather inefficient.
This is the simple, obvious fix for that issue - when encoding a compressed message, just store the compressed version back in the message body and set the Codec to COMPRESSION_NONE so we don't try and compress it again.