CLOSES #35 Quoting issue #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We build GraphQL queries with Go templates. We were using a built-in `js` template function for escaping arbitrary strings before using them as JSON strings. Which _almost_ works; it's not the intended use case for `js`. We actually needed a custom template function, as implemented here. Most of the changes in this commit are simply replacing `js` with `json` where templates are defined. The meat of the commit is in `query.go`.
Rather than the approach of the previous commit of the `json` template function doing something special when the output of Marshal is a JSON string, by stripping the beginning and ending quotation marks, simply don't use the quotation marks in the templates in the first place.
vishakh-shukla
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We build GraphQL queries with Go templates. We were using a built-in
jstemplate function for escaping arbitrary strings before using themas JSON strings. Which almost works; it's not the intended use case
for
js. We actually needed a custom template function, as implementedhere.
Most of the changes in this commit are essentially replacing
jswithjsonwhere templates are defined. The meat of the commit is inquery.goandquery_test.go