This repository has been archived by the owner on Feb 15, 2023. It is now read-only.
Disable Husky in CI to prevent helm from failing on containerize #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As seen here: lint-staged/lint-staged#775, git add is not needed here any more
This prevents husky from being installed which is was failing due to not having the .git file in the Docker work dir
jmeis
approved these changes
Jul 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For package.json:
As seen here: lint-staged/lint-staged#775, git add is not needed here any more
For Dockerfile:
Changed the first npm install in order to stop husky from being installed
For experience_test.py:
Modified experience test to actually pass because there was some modification to the site that stops the right voice from being selected by default