Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script for rendering test files #78

Merged
merged 8 commits into from
Dec 9, 2020
Merged

Script for rendering test files #78

merged 8 commits into from
Dec 9, 2020

Conversation

mrsabath
Copy link
Member

@mrsabath mrsabath commented Dec 8, 2020

No description provided.

lumjjb
lumjjb approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@lumjjb lumjjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Awesome, this definitely helps a lot for testing. Just a couple notes for minor nits!

utils/renderTestFiles.sh Outdated Show resolved Hide resolved
utils/renderTestFiles.sh Outdated Show resolved Hide resolved
webhook.go Outdated Show resolved Hide resolved
@mrsabath mrsabath merged commit f6ef208 into master Dec 9, 2020
@mrsabath mrsabath mentioned this pull request Dec 9, 2020
Closed
@mrsabath mrsabath deleted the test-script branch May 11, 2021 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lumjjb lumjjb lumjjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mrsabath @lumjjb