Cleanup old ubiquity provisioner installation method and refactor acceptance test dir #201
Conversation
Its ready to merge to dev, waiting for code review. |
There was a problem hiding this comment.
Reviewable status: 0 of 32 files reviewed, 1 unresolved discussion (waiting on @shay-berman, @olgashtivelman, and @yadaven)
Dockerfile.Flex, line 14 at r1 (raw file):
WORKDIR /root/ COPY --from=0 /go/src/github.com/IBM/ubiquity-k8s/ubiquity-k8s-flex . COPY --from=0 /go/src/github.com/IBM/ubiquity-k8s/scripts/setup_flex.sh .
did you also move this file to the scripts folder as part of some other commit? because I dont see any file like: scripts/setup_flex.sh in the dev branch.
There was a problem hiding this comment.
Reviewable status: 0 of 32 files reviewed, 1 unresolved discussion (waiting on @shay-berman and @yadaven)
Dockerfile.Flex, line 14 at r1 (raw file):
Previously, olgashtivelman wrote…
did you also move this file to the scripts folder as part of some other commit? because I dont see any file like: scripts/setup_flex.sh in the dev branch.
yes I did
you don't see it in the dev branch yet, because in this PR (not in dev yet) i moved the file to the new location. See the commit of this PR and u will see that the file moved to the new location.
There was a problem hiding this comment.
Reviewable status: 0 of 32 files reviewed, all discussions resolved (waiting on @yadaven)
Dockerfile.Flex, line 14 at r1 (raw file):
Previously, shay-berman wrote…
yes I did
you don't see it in the dev branch yet, because in this PR (not in dev yet) i moved the file to the new location. See the commit of this PR and u will see that the file moved to the new location.
ok i guess it was some hidden change i missed :)
There was a problem hiding this comment.
Reviewable status: 0 of 32 files reviewed, all discussions resolved (waiting on @yadaven)
This PR is for removing old files that are no longer relevant in the project. Below the list:
Relocate the [deploy/k8s_deployments/setup_flex.sh] to [scripts/setup_flex.sh] and update Dockerfile.Flex according.
Reorganized the acceptance test scripts for simplicity. Just move all the acceptance test scripts to a dedicated directory scripts/acceptance_tests (before it was spread across ./scripts and ./deploy directory).
Same clean up was done on the ubiquity repo for ubiquity server -> IBM/ubiquity#221
This change is